HBASE-29871 During WAL write times out add DataNode address in. the exception message #7719
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaijosh
reviewed
Feb 9, 2026
| if (evt instanceof IdleStateEvent && ((IdleStateEvent) evt).state() == READER_IDLE) { | ||
| promise | ||
| .tryFailure(new IOException("Timeout(" + timeoutMs + "ms) waiting for response")); | ||
| promise.tryFailure(new IOException( |
Contributor
There was a problem hiding this comment.
@srinireddy2020
In other two places we are logging "channel.remoteAddress" in message and here dnInfo.toString.
Can't we keep it consistent?
Contributor
Author
There was a problem hiding this comment.
In the method parameter already having the DN details so no need to call channel.remoteAddress.
Contributor
|
Please fix the spotless issue? |
srinireddy2020
force-pushed
the
HBASE-29871
branch
from
f7102a3 to
435757a
Compare
Contributor
Author
Spot less fixed. please check |
guluo2016
reviewed
Feb 10, 2026
| } | ||
| String logInfo = "ack with firstBadLink as " + resp.getFirstBadLink(); | ||
| String logInfo = | ||
| "ack with firstBadLink as " + resp.getFirstBadLink() + " from datanode " + dnInfo; |
Member
There was a problem hiding this comment.
Overall looks good. Just some minor nits.
In a previous change, we print both the hostname and IP when printing datanode info, details see: #6148
It might be better to follow that same pattern here?
Contributor
Author
There was a problem hiding this comment.
Comment addressed, please check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better debug, add datanode address to the exception message during WAL write times out